This repository has been archived by the owner on Dec 4, 2023. It is now read-only.
fix: Pass skipStep on main branch #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
approved these changes
Jan 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when you define a
skip_step, this will be ignored when the size limit runs on the main/master branch. This can lead to discrepancies between runs on master & on the PRs, plus results in additional time. For sentry-javascript, this means each time on the master branch we re-run yarn install & yarn build for the size check, even though these things have been run & cached before.I am not sure if this was done on purpose here #4, but it appears to me as if that would not be necessary here.
While at it, I also fixed another issue I noticed: Previously, if there have been changes initially, then you update the PR and have no changes, the comment may not have been updated. Now, we always update the comment if there has been one before.